Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ› οΈ μœ μ € 이름 / λ‹‰λ„€μž„ 뢄리 #91

Merged
merged 6 commits into from
Jun 5, 2024
Merged

πŸ› οΈ μœ μ € 이름 / λ‹‰λ„€μž„ 뢄리 #91

merged 6 commits into from
Jun 5, 2024
+50 βˆ’39

Conversation

Legitgoons
Copy link
Member

@Legitgoons Legitgoons commented Jun 5, 2024 •
edited
Loading

μž‘μ—… 이유

#89 이슈 처리


μž‘μ—… 사항

1️⃣ User Interface μˆ˜μ •

  • λ‹‰λ„€μž„μ— ν•΄λ‹Ήν•˜λŠ” username 속성 μΆ”κ°€
interface User {
  id: number;
  profileImage: string;
  name: string; // 이름
  username: string; // λ‹‰λ„€μž„(μΆ”κ°€)
//...
}

2️⃣ username μ‚¬μš© κΈ°λŠ₯ μˆ˜μ •

  • Feedμ—μ„œ name λŒ€μ‹  username μ‚¬μš©ν•˜λ„λ‘ μˆ˜μ •
  • Profileμ—μ„œ username μ‚¬μš©

리뷰어가 μ€‘μ μ μœΌλ‘œ 확인해야 ν•˜λŠ” λΆ€λΆ„

  • nameκ³Ό username이 μ μ ˆν•˜κ²Œ μ‚¬μš©λ˜κ³  μžˆλŠ”μ§€
  • Wiki의 User Interface와 μΌμΉ˜ν•˜λŠ”μ§€

λ°œκ²¬ν•œ 이슈

#92 #93
git의 였λ₯˜μΈμ§€ resetν–ˆλ˜ 컀밋듀이 κ·ΈλŒ€λ‘œ pushλ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€. bfbb35b와 a8f3160 컀밋은 읽지 μ•ŠμœΌμ…”λ„ λ¬΄λ°©ν•©λ‹ˆλ‹€.

@Legitgoons Legitgoons self-assigned this Jun 5, 2024
@aws-amplify-ap-northeast-2 AWS Amplify (ap-northeast-2)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-91.d37mn03xh3qyyz.amplifyapp.com

@psychology50
Copy link
Member

image

ν˜Ήμ‹œ User μΈν„°νŽ˜μ΄μŠ€μ— string νƒ€μž…μ˜ contentλŠ” μ–΄λ–€ 정보죠?

psychology50
psychology50 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@psychology50 psychology50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ­”κ°€ κ·Έλž˜λ„ μ˜λ―ΈμžˆλŠ” μ½”λ“œ 리뷰 ν•΄λ“œλ¦¬λ €κ³  각작고 λ΄€λŠ”λ° κ·Έλƒ₯ name을 username으둜 μˆ˜μ •ν•œ 것듀 λΏμ΄λ„€μš”; λ¨Έμ“±.

λ””μ½”μ—μ„œλ„ 이야기 ν–ˆμ§€λ§Œ μ’‹μ•„μš” μˆ«μžμ— 따라 우츑 μ•„μ΄μ½˜μ΄ μ›€μ§μ΄λŠ” ν˜„μƒμ΄ μžˆλŠ”λ°, μš°μ„  이번 PRκ³ΌλŠ” λ¬΄κ΄€ν•œ λ‚΄μš©μ΄λΌ approve ν•˜κ² μŠ΅λ‹ˆλ‹€~

src/app/mocks/consts/user.ts Show resolved Hide resolved
@psychology50
Copy link
Member

μ•„, content!!! μ €κ±° μƒνƒœ λ©”μ‹œμ§€λΌκ³  ν•˜μ…¨λŠ”λ° 없어도 될 것 κ°™μ•„μš”

@Legitgoons
Copy link
Member Author

ν•΄λ‹Ή ν•­λͺ© 이슈둜 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€. 병합 ν›„ μΆ”ν›„ μ²˜λ¦¬ν•˜κ² μŠ΅λ‹ˆλ‹€!

@Legitgoons Legitgoons merged commit 915f9ed into main Jun 5, 2024
2 checks passed
@Legitgoons Legitgoons deleted the fix/division-user-name branch June 5, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychology50 psychology50 psychology50 approved these changes

@BangDori BangDori Awaiting requested review from BangDori

Assignees

@Legitgoons Legitgoons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Legitgoons @psychology50